search

helgoboss / reaper-rs

Rust bindings for the REAPER C++ API
MIT License
82 stars 8 forks source link

Build failed for reaper-med on core-error crate #52

Closed iluvcapra closed 2 years ago

iluvcapra commented 2 years ago

I tried building a new plugin crate today per the instructions and I had an error:

Compiling core-error v0.0.0
error: failed to run custom build command for `core-error v0.0.0`

Caused by:
  process didn't exit successfully: `/Users/jamie/src/my_reaper_extension/target/debug/build/core-error-bc87a85b1dd91273/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'Rustc to give us its version', /Users/jamie/.cargo/registry/src/github.com-1ecc6299db9ec823/core-error-0.0.0/build.rs:4:62
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I checked core-error here on github and while there wasn't anything suggestive of a problem in the issues it sorta looks like the project isn't being maintained anymore. In any case I commented-out reaper-med from my dependencies and now cargo build is successful.

iluvcapra commented 2 years ago

Just doing some more digging it looks like this is fixed on the master of core-error but it hasn't made its way to crates.io.

helgoboss commented 2 years ago

Ah okay. I slightly remember running into this as well recently but forgot how I solved it. I suppose its due to helgoboss-midi https://github.com/helgoboss/helgoboss-midi/issues/1. BTW, are you using reaper-rs master? The version on crates.io is super old. master branch is a better choice. But be aware of PCM sink and PCM source APIs, they are undergoing some slight changes, also in the medium-level API.

iluvcapra commented 2 years ago

I can confirm I'm using the GitHub master branches for these and not the ones on crates.io.

I tried pulling core-error from its master in my toml as well and that installs fine, but cargo still tries to install the old version that fails, I don't seem to be able to override the underlying dependency.

helgoboss commented 2 years ago

@iluvcapra Do you still have this problem? The GitHub Actions workflows all run successfully now running with Rust 1.59 (have fixed a couple of other things).

One thing to point out: Because reaper-rs is a library rather than an application, I chose to not commit Cargo.lock to the repository. That's the official recommendation and that's why reaper-rs builds are not 100% reproducible.

helgoboss commented 2 years ago

Please reopen if you still have this issue.

iluvcapra commented 2 years ago

Yep working for me now, close it up.