search

helhum / TYPO3-Distribution

A distribution package for TYPO3 CMS with added typo3_console support
81 stars 19 forks source link

Database Port/Socket ignored when configuration gets loaded #8

Closed jdoubleu closed 7 years ago

jdoubleu commented 7 years ago

The conf/env.yml ignored the environment variables for the databse port/socket.

helhum commented 7 years ago

Thanks for your pull request.

However adding these values to be taken from env, will lead to the user being asked to provide this value during setup. That is especially unwanted, as you will never need to provide socket and port and both also only when deviating from defaults.

This means that if you need it in your project nevetheless, then do so in your projects setup. I won't change these values here though, to keep simple.

jdoubleu commented 7 years ago

But currently you have to provide port and/or socket anyways: screen shot 2017-09-22 at 13 06 45 (run composer create-project helhum/typo3-distribution my-project).

I see no difference in the configuration set by an empty variable or and empty value.

helhum commented 7 years ago

you are right. sorry for the hassle and thanks for the patch.