helidon-io / helidon-build-tools

Build tools for the Helidon Project
https://helidon.io
Apache License 2.0
35 stars 35 forks source link

CLI - proxy variable handling #778

Open danielkec opened 2 years ago

danielkec commented 2 years ago

CLI parses http_proxy and https_proxy by simply splitting hostname:port with :. We should support cases with trailing / which is fairly common and also proxies with username/password(URI syntax).

Also we should consider changing the priority to lower_case variant.

danielkec commented 2 years ago

https://github.com/oracle/helidon-build-tools/blob/ca162dd81e825ddde388a5944eb3ed378d63e8af/common/common/src/main/java/io/helidon/build/common/Proxies.java#L148-L170