Use Hamcrest assertions instead of JUnit

[tomas-langer]

Environment Details

• Helidon Version: 2.0.0

• Whole code base

Problem Description

Currently we have a few tests that still use JUnit assertions, such as assertEquals(actual, expected, "Test a and b are equal") all of these should be replaced with Hamcrest, such as: assertThat("Test a and b are equal", actual, is(expected)))

There are a few assertions we can use: fail("") assertAll() assertThrows

• [ ] archetypes/se/target/test-classes/projects/it1/project/it1
• [ ] archetypes/se/target/test-classes/projects/it2/project/it2
• [ ] archetypes/se/target/test-classes/projects/it3/project/it3
• [ ] common/common
• [ ] common/http
• [ ] common/reactive
• [ ] config/encryption
• [ ] config/object-mapping
• [ ] dbclient/jdbc
• [ ] dbclient/mongodb
• [ ] examples/cors
• [ ] examples/employee-app
• [ ] examples/microprofile/hello-world-implicit
• [ ] examples/microprofile/mp1_1-static-content
• [ ] examples/microprofile/openapi-basic
• [ ] examples/openapi
• [ ] examples/quickstarts/helidon-quickstart-mp
• [ ] examples/quickstarts/helidon-quickstart-se
• [ ] examples/quickstarts/helidon-standalone-quickstart-mp
• [ ] examples/quickstarts/helidon-standalone-quickstart-se
• [ ] examples/webserver/basics
• [ ] examples/webserver/comment-aas
• [ ] examples/webserver/jersey
• [ ] examples/webserver/tutorial
• [ ] integrations/cdi/common-cdi/reference-counted-context
• [ ] integrations/cdi/datasource-hikaricp
• [ ] integrations/cdi/datasource-ucp
• [ ] integrations/cdi/eclipselink-cdi
• [ ] integrations/cdi/jpa-cdi
• [ ] integrations/cdi/jpa-weld
• [ ] integrations/cdi/jta-cdi
• [ ] integrations/cdi/jta-weld
• [ ] integrations/cdi/oci-objectstorage-cdi
• [ ] media/common
• [x] messaging/kafka
• [x] messaging/messaging
• [ ] metrics/metrics
• [ ] microprofile/config
• [ ] microprofile/fault-tolerance
• [ ] microprofile/jwt-auth
• [x] microprofile/messaging
• [x] microprofile/reactive-streams
• [ ] microprofile/openapi
• [ ] microprofile/websocket
• [ ] openapi
• [ ] security/providers/oidc-common
• [ ] tests/apps/bookstore/bookstore-mp
• [ ] tests/apps/bookstore/bookstore-se
• [ ] tests/apps/bookstore/common
• [ ] tests/integration/kafka
• [ ] tests/integration/mp-ws-services
• [ ] tests/integration/native-image/se-1
• [ ] tests/integration/webclient
• [ ] webserver/jersey
• [ ] webserver/tyrus

[romain-grecourt]

Two items have been fixed in helidon-3.x, and will need to be backported in 2.x:

• https://github.com/oracle/helidon/pull/4886
• https://github.com/oracle/helidon/pull/4898

[Captain1653]

@romain-grecourt Can any contributor (not a member of helidon) do backport? I can try to do it. Are there any instructions for backport process in the documentation?

[romain-grecourt]

You can do a backport. There is no special process at the moment (though we've been working on one recently).

A git cherry-pick should do the trick.

[Captain1653]

@romain-grecourt Should I backport all these PR into helidon-4.x ?

[romain-grecourt]

@romain-grecourt Should I backport all these PR into helidon-4.x ?

Yes, please !