search

helidon-io / helidon

Java libraries for writing microservices
https://helidon.io
Apache License 2.0
3.44k stars 562 forks source link

4.x: Support for OKE Workload identity in OCI integration for Service registry #8862

Closed tomas-langer closed 1 week ago

tomas-langer commented 3 weeks ago

Description

Adds OKE workload authentication details provider Extracted some authentication details providers to separate modules (resource and instance principal) Marked as preview feature (production ready, may have some changes) for service registry

A few fixes in Builder and Config metadata (+ test update)

Documentation

Documentation of service registry features is now only in readme files

arjav-desai commented 2 weeks ago

a general nitpick: use full name i.e. authentication instead of atn, all over.

tomas-langer commented 1 week ago

a general nitpick: use full name i.e. authentication instead of atn, all over.

@arjav-desai do you mean in class names, comments, documentation, config or all?

Because: OciAtnMethod would become OciAuthenticationMethod, and the configuration keys would be authentication-method instead of atn-method, allowed-authentication-methods instead of allowed-atn-methods.

I am OK to replace this, but it will be more "chatty" (we already use these abbreviations in security)

tomas-langer commented 1 week ago

I have resolved all comments.