search

helio-fm / helio-sequencer

Libre music sequencer for desktop and mobile platforms
https://helio.fm
GNU General Public License v3.0
3.09k stars 115 forks source link

Add Chinese Font to solve the problem can not be displayed #137

Closed YuzukiTsuru closed 4 years ago

YuzukiTsuru commented 5 years ago

Add Chinese Font to solve the problem can not be displayed

peterrudenko commented 4 years ago

Thanks for the suggestion.

I believe it's better to avoid using built-in fonts, mainly for the reason it bloats the binary size (+7Mb for this font), so a lot of people are gonna pay for what they don't really use.

I'd suggest to rely upon system fonts and provide a CJK font along with the installer instead. Additionally, the app is to prefer some fonts on the first start: currently, it only looks for Noto or Noto CJK font, if it's present (please refer to #59 and #93), so maybe it should have a list of preferred fonts, e.g. including this Source Han Sans?

YuzukiTsuru commented 4 years ago

Thanks Suggest，I Think System built-in language font can be used.

Only one preprocessor macro is needed

------------------ Original ------------------ From: Peter Rudenko <notifications@github.com> Date: Mon,Oct 21,2019 4:22 PM To: helio-fm/helio-workstation <helio-workstation@noreply.github.com> Cc: Gloomy Ghost <740291272@qq.com>, Author <author@noreply.github.com> Subject: Re: [helio-fm/helio-workstation] Add Chinese Font to solve the problem can not be displayed (#137)

YuzukiTsuru commented 4 years ago

close for anther pr!