helio-fm / helio-sequencer

One music sequencer for all major platforms, desktop and mobile
https://helio.fm
GNU General Public License v3.0
3.04k stars 115 forks source link

Fixed important accidental note deletion bug by slightly restructuring mouse event handling + other slight tweaks #241

Closed ryanpmcguire closed 1 year ago

ryanpmcguire commented 1 year ago
peterrudenko commented 1 year ago

Thanks! Noticed a couple of things:

ryanpmcguire commented 1 year ago

I've been playing around with the code relating to these issues today. The way the various mouse events are handled within noteComponent.cpp, pianoRoll.cpp, and rollBase.cpp required some slight restructuring. Upon seeing the code, I think you will find it is a cleaner way to deal with some things. When all the bugs are worked out, I will update this pull request for your convenience.

Thank you for your detailed attention to these contributions - I appreciate having such a good response from a dev such as you.