search

heliomarpm / udemy-downloader-gui

A desktop application for downloading Udemy Courses
MIT License
1.03k stars 209 forks source link

1080p image is downloaded as 720p. #159

Closed Canmemis closed 4 months ago

Canmemis commented 1 year ago

Udeler | Udemy Course Downloader

1.12.7

Account Type?

Personal

Steps to reproduce

Hello,

Currently, when I want to download from Udeler, it downloads as 720p even though the video quality is 1080p. https://github.com/heliomarpm/udemy-downloader-gui/releases I am using the 64 bit version available here. in the settings I selected the option to download in highest resolution. but it downloads in 720p. image image

training normally supports 1080p. image

https://www.udemy.com/course/python-baslangictan-ileri-seviye-yazilim-dersleri/learn/lecture/23587198#questions

✔️ Expected Behavior

Make it download videos in 1080p files as 1080p.

🔍 Additional context

Windows 11

Canmemis commented 1 year ago

Is the problem solved? I don't quite understand.

heliomarpm commented 1 year ago

Is the problem solved? I don't quite understand.

In the courses I have access to, I was able to download in 1080p without any problems. Did you save the information in the settings tab before starting the download?

Nickyg001 commented 12 months ago

I noticed this problem too. Even if the video quality is set to high (1080), some videos are downloaded at 1080, others at 720. I asked the teacher what quality he had put the videos in and he confirmed 1080, also because he published the video yesterday so they were recently recorded ( therefore with a video quality in terms of constant resolution at 1080p)

another thing I noticed that when downloading with MAXIMUM download quality, the videos are much slower to download and the same file at 1080 is also lighter... example: 720p = 44mb 1080p = 36mb

Will it be strange? but Windows Explorer tells me these megabytes..

heliomarpm commented 12 months ago

I noticed this problem too. Even if the video quality is set to high (1080), some videos are downloaded at 1080, others at 720. I asked the teacher what quality he had put the videos in and he confirmed 1080, also because he published the video yesterday so they were recently recorded ( therefore with a video quality in terms of constant resolution at 1080p)

another thing I noticed that when downloading with MAXIMUM download quality, the videos are much slower to download and the same file at 1080 is also lighter... example: 720p = 44mb 1080p = 36mb

Will it be strange? but Windows Explorer tells me these megabytes..

Really, 720 files should always be smaller in megabytes. The Udemy API does not provide 1080 quality by default, to download this quality you need to access the m3u8 playlist, I have not yet identified this problem, but one possibility is that in some classes you will not find the highest quality in the list.

I'll try to get an account to test.

feriishere commented 7 months ago

yeah there is no 1080p in the list, but works amazing. i guess the originial one supports 1080p but for some reason this repo is much better

heliomarpm commented 4 months ago

New version available, check.