search

heliophysicsPy / gallery

A Gallery of Examples and Tutorials
4 stars 9 forks source link

Added inline images. #21

Open nickssl opened 4 years ago

nickssl commented 4 years ago

Added inline images because sphinx cannot get the plot images using pyqt5.

nickssl commented 4 years ago

Can you accept this?

Cadair commented 4 years ago

Where is the requirement for pyqt5 coming from? Are they matplotlib plots?

nickssl commented 4 years ago

Where is the requirement for pyqt5 coming from? Are they matplotlib plots?

It is using pyqtgraph: http://www.pyqtgraph.org/

Cadair commented 4 years ago

Ah right, I think it would be better if you uploaded the images to this repo rather than linking them across site. Is there a good reason to not do that?

Cadair commented 4 years ago

I also added an issue on sphinx gallery to directly support pyqtgraph.

nickssl commented 4 years ago

Ah right, I think it would be better if you uploaded the images to this repo rather than linking them across site. Is there a good reason to not do that?

The main reason I did not upload the images to the repository is that I did not want to make it large size on disk. If many people upload images then the source code will be too large. Of course, right now there aren't many examples, so this is not a real issue currently, and I can upload the images if you want.