Closed jeandet closed 5 months ago
The checker script does not raise anymore if a project fails so we always check all projects and it makes the output more readable and natural.
That was fast! I didn't expect you to do this until at least next week. Lol
We need to loosen these checks, however. It probably shouldn't check anything in projects_unevaluated.yml
since that category is by definition projects without badges. And we don't currently require projects to pick at least one keyword from every category, so that rule should be removed too.
@sapols, my bad, it makes sense to skip projects_unevaluated.yml
.
On the keyword side I only check that each project has at least on functionality related keyword as requested here Keywords that are related to your project's functionality *
.
I can remove the *
in the document and the check if you want.
@jeandet Ah I see. You just interpreted Keywords that are related to your project's functionality *
too literally. We don't literally mean a keyword from the "functionality" category, we just mean projects should use keywords in general. Please do not remove the *
in the document but please do remove the check.
@sapols, I removed the check and just added a simple warning if a project has 0 keywords (which should be suspicious).
GeospaceLAB project issue seems legit, its documentation field is set to ['https://img.shields.io/badge/Good-brightgreen.svg', 'Partially met']
, I can fix it in this PR but not sure which of the badge or the evaluation is wrong.
Later in another PR, I'll also check that projects only uses documented fields (should help to spot any typo).
@jeandet Thanks! About GeospaceLAB, yeah people mix up those URLs and strings sometimes. Their documentation status is in fact "Good" so it's the 'Partially met'
that needs to change.
Once you fix GeospaceLAB, there won't be any more errors right? If every project in projects_core.yml
and projects.yml
has at least one keyword now (and I believe they do?) I wouldn't want to start allowing new projects without at least one keyword. So can you maybe change that warning back to an error?
@sapols Sure, I fixed GeospaceLAB and made keyword absence an error.
@sapols a little more work for you or related projects maintainers 😅: