heliophysicsPy / heliophysicsPy.github.io

https://pyhc.org
MIT License
15 stars 52 forks source link

Displaying approved PHEPs; include PHEP-1 #328

Closed jtniehof closed 4 months ago

jtniehof commented 5 months ago

This is a terrible first shot at displaying approved pheps, by someone who really doesn't understand Jekyll :) but hopefully it can get the idea across. It's sort of the complement to heliophysicsPy/standards#26 ...that has a Python snippet which extracts the necessary yaml, and this then just dumps the YAML, more-or-less. Untested.

Maybe we should have the DOI in there somewhere, too.

sapols commented 5 months ago

Apparently the liquid conditional logic isn't gonna let us do that or, so my latest commit, while uglier in code, is needed to fix the display. With that fix the page now displays like:

Screen Shot 2024-04-16 at 4 40 44 PM

Calling that a stopping point. I'll continue working on this in the morning.

(And I'll note I intend to move this under a subpage of Documents rather than adding a PHEPs nav bar item.)

jtniehof commented 5 months ago

That's probably actually more clear. Thanks for getting that working. I'll poke around and see what I can do about including DOI.

jtniehof commented 5 months ago

I just pushed an update to heliophysicsPy/standards#26 that inserts the DOI into the YAML, so we will want an additional column. I'm thinking at the very end (after revision) and then:

          <td>
            <a href="https://doi.org/{{ phep.DOI }}">doi:{{ phep.DOI }}</a>
          </td>
sapols commented 5 months ago

I'll note that for the DOI to display properly in the table, the DOI entry in the yaml should look like 10.5281/zenodo.10988007 (e.g. don't include http:// in that entry).

sapols commented 5 months ago

Render with the DOI column:

Screen Shot 2024-04-17 at 11 42 05 AM
jtniehof commented 4 months ago

Just to note, once heliophysicsPy/standards#22 is merged and the release cut, I will finish the Zenodo upload and mark this ready to merge.

jtniehof commented 4 months ago

Zenodo is uploaded, so @sapols , ready to merge!