search

heliophysicsPy / pyhc-core

A package to install all PyHC core packages.
https://pypi.org/project/pyhc-core/
MIT License
1 stars 0 forks source link

Does `pip install kamodo` miss anything? #3

Open sapols opened 5 months ago

sapols commented 5 months ago

We've tended to install Kamodo via git in the past. Yet this simply installs it via pip install kamodo. Ask the package maintainers if this is an issue or not.

sapols commented 5 months ago

If we do end up adding something missing, publish the new PyPI version via GitHub Actions (https://github.com/heliophysicsPy/pyhc-core/issues/7).

sapols commented 5 months ago

Emailed Darren about this.

sapols commented 4 months ago

Heard back from Darren, and yes it is missing stuff:

So unfortunately the development of Kamodo has changed direction a few times at the beginning. One consequence is that ‘pip install kamodo’ just installs the Kamodo-core and thus none of the CCMC model readers or advanced viaualization. On the other hand, ‘pip install kamodo-ccmc’ does install the full Kamodo package. However, that right now is more than a year out of date and is missing many upgrades and fixes. That’s why for now we are recommending to install from GitHub. It’s on my list to fix this summer and get PyPI updated with the latest version.

sapols commented 3 months ago

I believe pyproject.toml supports git dependencies with this syntax:

dependencies = [
  "sphinx@git+https://github.com/sphinx-doc/sphinx",
]

(source / alt source)

So might be as simple as replacing "kamodo", in the dependencies with "kamodo@git+https://github.com/nasa/Kamodo.git",

sapols commented 3 months ago

I had to use "kamodo-ccmc@git+https://github.com/nasa/Kamodo.git", instead because pip complained the package metadata was named kamodo-ccmc not just kamodo.

sapols commented 3 months ago

WHELP, never mind. I set up Kamodo to install from git, only for PyPI to error during the upload with a message stating that it's against their rules to have package dependencies that install from git: https://github.com/heliophysicsPy/pyhc-core/actions/runs/10375172727/job/28724242403

So we've hit a wall. Kamodo will simply have to fix its pip install so that installing from git won't be required.