search

helior / react-highlighter

:high_brightness: Highlight text using React
MIT License
157 stars 42 forks source link

make `create-react-class` and `prop-types` as runtime dependencies #41

Closed nachikethashu closed 7 years ago

nachikethashu commented 7 years ago

as per https://github.com/helior/react-highlighter/commit/ec2ae091898ac666a184a9b102484cc1c6d71543 create-react-class and prop-types are declared as devDependencies which leads to errors if we have our own build-system instead of npm which just relies on run time dependencies.

lpommers commented 7 years ago

We're seeing this as well in our build system; would greatly appreciate. 🙇