search

helior / react-highlighter

:high_brightness: Highlight text using React
MIT License
157 stars 42 forks source link

getDefaultProps usage #44

Closed mvolkmann closed 7 years ago

mvolkmann commented 7 years ago

I get lots of these warnings in the browser dev tools console:

Warning: getDefaultProps is only used on classic React.createClass definitions. Use a static property named defaultProps instead.

It would be great if this library could be updated to not use getDefaultProps. I see this is on line 24 of https://github.com/helior/react-highlighter/blob/master/lib/highlighter.js.

ericgio commented 7 years ago

Submitted #45 to address this and another warning.

helior commented 7 years ago

Thanks @mvolkmann, @ericgio. This issue is ready to be closed.