search

helior / react-highlighter

:high_brightness: Highlight text using React
MIT License
157 stars 42 forks source link

change the children's key to be unique to able html mouse events #46

Open hartuvofir opened 7 years ago

hartuvofir commented 7 years ago

The File i changed is lib/highlighter.js . The problem was that the item key (count), was not unique between the items (i debug the html) - and react cant capture click/mouse events in this case.

I changed it to be based by the Address(string), which is unique.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling cac04951719ea0dfcff7500a66f5d90a4937c20b on bookmd:master into on helior:master.

janmyler commented 7 years ago

@hartuvofir I'd suggest you remove all the IntelliJ related files from the PR and keep only the relevant changes.