search

helios-ag / FMBbCodeBundle

:capital_abcd: BBCode bundle for Symfony projects
Other
57 stars 35 forks source link

Make bundle compatible with SF3.0 #130

Closed helios-ag closed 6 years ago

alquerci commented 8 years ago

@helios-ag Need to create a dedicated branch for that.

doppynl commented 8 years ago

Is there any progress on this? What is preventing the version bump to 3.0?

GuillaumeHemmen commented 8 years ago

Hi @helios-ag any news about this issue? I'm really impatient to re-use your bundle into my websites.

helios-ag commented 8 years ago

Hi @doppynl and @GuillaumeHemmen looks like @alquerci is working on it https://github.com/alquerci/FMBbCodeBundle/commits/fix-versioning . There is also 3.0 branch of the bundle, which should work too, you can download it with 'dev-3.0' version constraint in composer.json

helios-ag commented 8 years ago

see also #136

GuillaumeHemmen commented 8 years ago

cheers @helios-ag !

helios-ag commented 8 years ago

Tagged as 7.0

alquerci commented 8 years ago

On the readme of the branch 3.0 there is a good base: :+1: @helios-ag

For symfony <3.0, use latest major version 6

composer require helios-ag/fm-bbcode-bundle:^6

for Symfony 3

composer require helios-ag/fm-bbcode-bundle:^7

Ref from the composer doc for using ^ instead of ~ https://getcomposer.org/doc/articles/versions.md#caret

We should use the Symfony development process https://youtu.be/qlrwfOL0230?t=16m50s But maybe just using one branch for each major version instead of minor one.

helios-ag commented 8 years ago

Thank you @alquerci for sharing Fabien's speech. I will update readme accordingly. And separate branches for majors looks fine for me. But versioning for this bundle wasn't followed semantic versioning before (i synced it with decoda's lib).

ghost commented 6 years ago

I think that ticket can be closed, correct?

helios-ag commented 6 years ago

@hipio seems so, thanks!