helios-ag / FMBbCodeBundle

:capital_abcd: BBCode bundle for Symfony projects
Other
57 stars 35 forks source link

Tried to make the bundle SF4 compatible #147

Open ghost opened 6 years ago

ghost commented 6 years ago

@helios-ag since I want to update one of my applications, I had to upgrade this bundle to Symfony4, so I did. I made some tiny codestyle changes and fixed few things here and there.

Major points are that the sensio/distribution-bundle won't be supported for Symfony4 and symfony/assetic-bundle is deprecated. I've just added a public_path since symfony/assetic-bundle was only required for it's output path (as far as I could see). The public_path defaults to the SF4 default for the web folder (which is /public).

If you want me to test anything else or got any feedback, let me know.

helios-ag commented 6 years ago

Thanks for this work, ill try to check this on weekend.

ghost commented 6 years ago

I'm currently using this dev version on a personal project of mine and it seems to work as expected (at least for [b]. [u] and [url] tags). If you find anything that I should fix, do tell! :smile: