helios-ag / FMBbCodeBundle

:capital_abcd: BBCode bundle for Symfony projects
Other
57 stars 35 forks source link

Error with new BBCodes of PHPDecoda #28

Closed remontees closed 11 years ago

remontees commented 11 years ago

Hello,

You can see the discussion of the problem here : https://github.com/milesj/php-decoda/issues/24#issuecomment-10697473

Alternative links and abbr aren't working.

Thanks,

remontees

helios-ag commented 11 years ago

Ok i'll take a look

helios-ag commented 11 years ago

I have checked issue you posted above, and it worked fine, i added functional test to check [abbr] bbcode. As u can see, test are passed.

remontees commented 11 years ago

And for the links with alternative text ?

Which parameters did you use for the test. For me, it doesn't work. It's very strange. Have you the title attribute parsed for ABBR ?

helios-ag commented 11 years ago

Look at Tests/Templating/BbcodeExtensionTest.phpL31 for abbr, [url] also woks fine.

remontees commented 11 years ago

I've this :

PHP Fatal error:  Class 'FM\BbcodeBundle\Tests\TwigBasedTestCase' not found in /var/www/Symfony2.1/vendor/helios-ag/fm-bbcode-bundle/FM/BbcodeBundle/Tests/Templating/BbcodeExtensionTest.php on line 12
PHP Stack trace:
PHP   1. {main}() /usr/bin/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46
PHP   3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130
PHP   4. PHPUnit_Runner_BaseTestRunner->getTest() /usr/share/php/PHPUnit/TextUI/Command.php:150
PHP   5. PHPUnit_Runner_BaseTestRunner->loadSuiteClass() /usr/share/php/PHPUnit/Runner/BaseTestRunner.php:104
PHP   6. PHPUnit_Runner_StandardTestSuiteLoader->load() /usr/share/php/PHPUnit/Runner   /BaseTestRunner.php:168
PHP   7. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Runner/StandardTestSuiteLoader.php:78
PHP   8. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:79
PHP   9. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:95

I swear it doesn't work. I've send the configuration. It's so strange. Because all of the others BBCode works fine !

Here's my twig :

{% filter bbcode_filter('bbcode_reportages')|ParseGalerie|ParseLogos|raw %}
{{ code }}
{% endfilter %}

In fact, I've understooden, all the attributes in BBCodes are not working with me.

helios-ag commented 11 years ago

What happened after applying only bbcode_filter('bbcode_reportages)?

remontees commented 11 years ago

I've the same bug, also if I deactivate Javascript support !

helios-ag commented 11 years ago

Can't reproduce error, tried with different configuration combinations. Tested on latest stable symfony (2.1.3).

remontees commented 11 years ago

I'm on 2.1.2, and I've this bug. It's strange.

remontees commented 11 years ago

I've updated to 2.1.4 and I have the SAME bug. It's very strange because it's always about the ="Machin bidule" attributes.

I tried this code :

[url="toto"]http://toto.fr[/url]

And I had a standard link without alternative text.

helios-ag commented 11 years ago

You should use [url] code in opposite way, ie [url="http://montagne-cable.legtux.org/reportages/reportage-tsf2-eclose"]toto[/url]

remontees commented 11 years ago

When I write it, I have toto without the link. Test yourself on your server with my param. You will see !

helios-ag commented 11 years ago

Thats my configuration for bundle:

fm_bbcode:
    filter_sets:
        forum_post_filter:
            locale: en
            xhtml: false
            filters: [ default, block, image, list, quote, text, url ]

this is how i used it

{%  filter bbcode_filter('forum_post_filter')%}
[b]asdasd[/b][quote="sdfsf"]sdsd[/quote]  [abbr="SATAaaa"]SATA[/abbr] [url]http://remontees.free.fr[/url]
[url="http://montagne-cable.legtux.org/reportages/reportage-tsf2-eclose"]toto[/url]
{% endfilter %}
remontees commented 11 years ago

It doesn't works for the link and for ABBR ! You should upgrade the README with this new code !

And for the quote, I've this :

<blockquote class="decoda-quote">
<div class="decoda-quote-body"> sdsd </div>
</blockquote>

But I haven't sdfsf in attribute !

helios-ag commented 11 years ago

Have you resolved, your issues with latest version of bundle?

remontees commented 11 years ago

No… :(