helios-ag / FMElfinderBundle

:file_folder: ElFinderBundle provides ElFinder integration with TinyMCE, CKEditor, Summernote editors
MIT License
274 stars 127 forks source link

Twig error after updating #330

Closed grimmlink closed 6 years ago

grimmlink commented 6 years ago
Issue Type:
Bundle Version:
Summary:

After updating the bundle i get this error:

Type error: Argument 1 passed to Twig_Environment::addExtension() must implement interface Twig_ExtensionInterface, boolean given, called in /data/www/dev/odt/marketplace/var/cache/dev/ContainerEitix01/appDevDebugProjectContainer.php on line 1795

The line in question:

$instance->addExtension(${($_ = isset($this->services['twig.extension.fm_elfinder_init']) ? $this->services['twig.extension.fm_elfinder_init'] : $this->getTwig_Extension_FmElfinderInitService()) && false ?: '_'});

Steps To Reproduce:

Updated from version 6 to version 8. I'm using sf3.4

Composer.json
        "php": ">=5.5.9",
        "doctrine/doctrine-bundle": "^1.6",
        "doctrine/orm": "^2.5",
        "incenteev/composer-parameter-handler": "^2.0",
        "sensio/distribution-bundle": "^5.0.19",
        "sensio/framework-extra-bundle": "^5.0.0",
        "symfony/monolog-bundle": "^3.1.0",
        "symfony/polyfill-apcu": "^1.0",
        "symfony/swiftmailer-bundle": "^2.6.4",
        "symfony/symfony": "3.4.*",
        "twig/twig": "^1.0||^2.0",

        "twig/extensions": "^1.5",
        "stof/doctrine-extensions-bundle": "~1.2",
        "friendsofsymfony/user-bundle": "~2.0",
        "geoip2/geoip2": "~2.0",
        "liip/imagine-bundle": "^1.9",
        "nelmio/cors-bundle": "^1.5",
        "grimmlink/mangopay-bundle": "dev-master",
        "vich/uploader-bundle": "^1.6",
        "willdurand/js-translation-bundle": "^2.6",
        "friendsofsymfony/ckeditor-bundle": "^1.1",
        "friendsofsymfony/jsrouting-bundle": "^2.2",
        "mangopay/php-sdk-v2": "^2.7",
        "algolia/search-bundle": "^3.1",
        "anthonymartin/geo-location": "^1.0",
        "presta/image-bundle": "^1.8",
        "helios-ag/fm-elfinder-bundle": "~8"
tifabien commented 6 years ago

Seems the error is not coming from your bundle upgrade 6->8 but seems related to the latest Symfony 3.4.16 version. I didn't have the error when running Symfony 3.4.15

tifabien commented 6 years ago

Confirmed. It's a Symfony issue and tracked here : https://github.com/symfony/symfony/issues/28658

helios-ag commented 6 years ago

Thanks for reporting guys, looks like we need to wait hotfix in symfony repo.

grimmlink commented 6 years ago

Aaah the issue wasn't declared when I searched for it. Thanks for your time !