fix a bug that it can't render form and ckeditor

helios-ag / FMElfinderBundle

:file_folder: ElFinderBundle provides ElFinder integration with TinyMCE, CKEditor, Summernote editors

MIT License

274 stars 127 forks source link

Closed l396635210 closed 5 years ago

l396635210 commented 5 years ago

I use the form will can't click choice the file. I modify that it can work fix a bug that it can't render form and ckeditor twig template.

Q	A
Bug fix?	[yes]
New feature?	[no]
BC breaks?	[no]
Deprecations?	[no]
Tests pass?	[no]
Fixed tickets	[comma-separated list of tickets fixed by the PR, if any]
License	MIT

helios-ag commented 5 years ago

This will break functionality of the bundle, because instances aren't named after editors name.

l396635210 commented 5 years ago

Or here

$editor = $parameters['editor'];    ->  $editor = $instance ?: $parameters['editor'];

helios-ag commented 5 years ago

It doesn't make sense, can you post gist with your bundle configuration (or better fork symfony-standard, so i can reproduce it)