helios-ag / FMElfinderBundle

:file_folder: ElFinderBundle provides ElFinder integration with TinyMCE, CKEditor, Summernote editors
MIT License
274 stars 127 forks source link

Mission option tmpPath under onedrive_setting #351

Closed DylanDelobel closed 5 years ago

DylanDelobel commented 5 years ago
Issue Type: Bug Report
Bundle Version: 9.2
Summary:

A missing option we can't configure

Steps To Reproduce:

With a simple config like this

fm_elfinder:
    instances:
        default:
            locale: '%locale%'
            editor: ckeditor
            path_prefix: '%client_uri%/' # for setting custom assets path prefix, useful for non vhost configurations, i.e. http://127.0.0.1/mysite/
            include_assets: true # disable if you want to manage loading of javascript and css assets manually
            connector:
                roots:       # at least one root must be defined, defines root filemanager directories
                    uploads:
                        driver: onedrive
                        upload_allow: ['image/png', 'image/jpg', 'image/jpeg']
                        upload_deny: ['all']
                        upload_max_size: 64M # also file upload sizes restricted in php.ini
                        onedrive_settings:
                            client_id: some_consumer
                            client_secret: con$umer
                            accessToken: token
#                            tmpPath: /tmp

The error is Undefined index: tmpPath

in vendor/helios-ag/fm-elfinder-bundle/src/Configuration/ElFinderConfigurationReader.php (line 388)

              $settings['tmpPath']           = $parameter['onedrive_settings']['tmpPath'];

Uncomment the tmpPath option and you get this error

Unrecognized option "tmpPath" under "fm_elfinder.instances.onedrive.connector.roots.uploads.onedrive_settings"

Because we can't set up this options

https://github.com/helios-ag/FMElfinderBundle/blob/master/src/DependencyInjection/Configuration.php#L260

Not sure if this options is needed or not, so here this issue