search

helios-ag / FMElfinderBundle

:file_folder: ElFinderBundle provides ElFinder integration with TinyMCE, CKEditor, Summernote editors
MIT License
274 stars 127 forks source link

Update twig extension to use supported Twig classes instead of legacy ones #374

Closed Lustmored closed 4 years ago

Lustmored commented 4 years ago

It is as simple as replacing Twig_* classes with actual classes that are supported and available in all twig versions. Also updated test to reflect those changes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #374 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #374   +/-   ##
=========================================
  Coverage     56.11%   56.11%           
  Complexity      261      261           
=========================================
  Files            14       14           
  Lines          1055     1055           
=========================================
  Hits            592      592           
  Misses          463      463
Impacted Files Coverage Δ Complexity Δ
src/Twig/Extension/FMElfinderExtension.php 52.94% <100%> (ø) 9 <1> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c5d0ec...f1a5c26. Read the comment docs.

helios-ag commented 4 years ago

Looks great! Thank you!