Symfony 5 support - Githubissues

Vincz commented 4 years ago

Short description of what this feature will allow to do: Symfony 5 support would be awesome :)

napestershine commented 4 years ago

$  composer require helios-ag/fm-elfinder-bundle
Using version ^9.3 for helios-ag/fm-elfinder-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Restricting packages listed in "symfony/symfony" to "5.0.*"
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - helios-ag/fm-elfinder-bundle 9.3.2 requires symfony/framework-bundle ~2.8|~3.0|~4.0 -> no matching package found.
    - helios-ag/fm-elfinder-bundle 9.3.1 requires symfony/framework-bundle ~2.8|~3.0|~4.0 -> no matching package found.
    - helios-ag/fm-elfinder-bundle 9.3 requires symfony/framework-bundle ~2.8|~3.0|~4.0 -> no matching package found.
    - Installation request for helios-ag/fm-elfinder-bundle ^9.3 -> satisfiable by helios-ag/fm-elfinder-bundle[9.3, 9.3.1, 9.3.2].

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

simplyniceweb commented 4 years ago

Please do! Thank you!

helios-ag commented 4 years ago

Probably will release SF5 compatible version during nearest weekend.

helios-ag commented 4 years ago

Tagged as pre-release v10 Drop any issues in here or create new ones, thanks

napestershine commented 4 years ago

Big Thanks

napestershine commented 4 years ago

@helios-ag I am just trying to install it on SF 5.

I am using FOSCKEditor

$  composer require helios-ag/fm-elfinder-bundle
Using version ^10.0 for helios-ag/fm-elfinder-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Restricting packages listed in "symfony/symfony" to "5.0.*"

Prefetching 2 packages 🎶 💨
  - Downloading (100%)

Package operations: 2 installs, 0 updates, 0 removals
  - Installing studio-42/elfinder (2.1.51): Loading from cache
  - Installing helios-ag/fm-elfinder-bundle (10): Loading from cache
Package zendframework/zend-code is abandoned, you should avoid using it. Use laminas/laminas-code instead.
Package zendframework/zend-eventmanager is abandoned, you should avoid using it. Use laminas/laminas-eventmanager instead.
Writing lock file
Generating autoload files
ocramius/package-versions: Generating version class...
ocramius/package-versions: ...done generating version class
Symfony operations: 1 recipe (eaa7c0a0832dfad6daa0ac4c55b9655b)
  -  WARNING  helios-ag/fm-elfinder-bundle (>=7.0): From github.com/symfony/recipes-contrib:master
    The recipe for this package comes from the "contrib" repository, which is open to community contributions.
    Review the recipe at https://github.com/symfony/recipes-contrib/tree/master/helios-ag/fm-elfinder-bundle/7.0

    Do you want to execute this recipe?
    [y] Yes
    [n] No
    [a] Yes for all packages, only for the current installation session
    [p] Yes permanently, never ask again for this project
    (defaults to n): y
  - Configuring helios-ag/fm-elfinder-bundle (>=7.0): From github.com/symfony/recipes-contrib:master
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!  
!!  In ArrayNode.php line 319:
!!                                                                                 
!!    Unrecognized option "include_assets" under "fm_elfinder.instances.default".  
!!     Available options are "connector", "cors_support", "editor", "editor_templ  
!!    ate", "fullscreen", "locale", "path_prefix", "relative_path", "theme", "tin  
!!    ymce_popup_path", "visible_mime_types".                                      
!!                                                                                 
!!  
!!  
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json to its original content.

helios-ag commented 4 years ago

Looks fine, but don't use recipe for now, it's outdated

napestershine commented 4 years ago

$ php bin/console elfinder:install

In ParameterBag.php line 98:

You have requested a non-existent parameter "locale". Did you mean one of these: "kernel.default_locale", "stof_doctrine_extensions.default_l
ocale"?

napestershine commented 4 years ago

After Fixing about with kernel.default_locale

$ php bin/console elfinder:install

In ArrayNode.php line 319:

  Unrecognized option "include_assets" under "fm_elfinder.instances.default". Available options are "connector", "cors_support", "editor", "edi  
  tor_template", "fullscreen", "locale", "path_prefix", "relative_path", "theme", "tinymce_popup_path", "visible_mime_types".

I didn't use symfony flex recipe this time.