search

helios-ag / FMElfinderBundle

:file_folder: ElFinderBundle provides ElFinder integration with TinyMCE, CKEditor, Summernote editors
MIT License
275 stars 128 forks source link

AWS s3 support not working correctly #495

Closed johanadivare closed 1 year ago

johanadivare commented 1 year ago

Describe the bug Right now when i configure s3 via https://github.com/helios-ag/FMElfinderBundle/blob/main/docs/flysystem.md#amazon-s3-configuration i get the following error: 

Attempted to load class "AwsS3V3Adapter" from namespace "League\Flysystem\AwsS3v3".
Did you forget a "use" statement for "League\Flysystem\AwsS3V3\AwsS3V3Adapter"?

I see in version 1.0.30 AwsS3Adapter https://github.com/thephpleague/flysystem-aws-s3-v3/blob/1.0.30/src/AwsS3Adapter.php was still on correct location but from version 2.0.0 they renamed to AwsS3V3Adapter https://github.com/thephpleague/flysystem-aws-s3-v3/blob/2.x/AwsS3V3Adapter.php

So i only think we only have support for thephpleague/flysystem-aws-s3-v3 version 1.0.x?

I changed the namespace in my vendor and it still not worked for me.

helios-ag commented 1 year ago

hi @johanadivare support of flysystem based on barryvdh/elfinder-flysystem-driver Probably needs to be checked if it can work with S3 Adapter v2

johanadivare commented 1 year ago

@helios-ag https://github.com/bayucandra/ckeditor-elfinder/blob/master/vendor/elFinder/php/connector.minimal.php indeed mentions the same import.

Do you mean i should check if it works with https://github.com/thephpleague/flysystem-aws-s3-v2/? I can't install this as its depended on league/flysystem 1 and i have other packages that require at least 2.0.0

johanadivare commented 1 year ago

@helios-ag i checked just now i was running on version 10.1 of this package after upgrading i didn't have any errors so this is already resolved in the newer versions. It was fixed with: https://github.com/helios-ag/FMElfinderBundle/pull/487

helios-ag commented 1 year ago

oh, great then! have a nice day!