helios-io / helios

reactive socket middleware for .NET
http://helios-io.github.io/
Apache License 2.0
453 stars 127 forks source link

All things considered, how about removing obsolete flag from legacy Helios 1.x APIs? #127

Closed brudo closed 7 years ago

brudo commented 7 years ago

As we know, further development of Helios is discontinued in favor of DotNetty. With this in mind a strong recommendation is given that newcomers to Helios try DotNetty instead. However, it seems that the most common scenarios where Helios might still be used going forward, if this advice is followed, will involve legacy code bases that were originally developed for the 1.x APIs, or hacking on the sample code, which is largely based on the legacy APIs, or other simple cases where Helios 1.x Reactors may be well suited.

This leads to a strange situation where, in one of the most common situations where Helios is likely to be used, I get deprecation warnings at build time. If the newer 2.x APIs are used, in some ways it feels like a larger risk due to the shorter history and more limited documentation / samples and there would seem to be a stronger case for choosing DotNetty instead, but there is no warning about it.

Considering how this has transpired, what about removing the deprecation warnings, so that the 1.x APIs are no longer differentiated as obsolete and are once again on the same footing as the 2.x APIs? (Otherwise I could continue using Helios 1.4.2, but then will not benefit from more recent bug fixes.)

brudo commented 7 years ago

Alternatively, could mark all Helios APIs deprecated / obsolete, consistent with the README documentation. In any case, the limited documentation and lack of maintenance / future bug fixes has convinced us to migrate away from it, as recommended by the author. I'm closing this now. The best to you.