search

heliosdesign / helios-audio-mixer

Web Audio API mixer library
https://heliosdesign.github.io/helios-audio-mixer/demo
MIT License
60 stars 11 forks source link

A Couple Small Issues #12

Closed dansundy closed 8 years ago

dansundy commented 8 years ago
  1. No semicolon at the end of closure causes concatenation error. (How's that for an alliteration!). I was using the unminified version.
  2. tweenGain expects the duration to be in seconds (ie it multiplies the number passed in by 1000). The docs show tween gain to be accepting milliseconds and it looks like the HTML5 doesn't manipulate the duration.

Let me know if you want me to submit a pull request for these things. And if so, how do you want the duration formatted (s or ms)?

iainmcampbell commented 8 years ago
  1. oops! probably should have a semicolon at the beginning and the end just to be safe.
  2. I think I set this to seconds to match the rest of the HTML5 audio element API. does that makes sense to you?

if you want to submit a pull request that would be great!

dansundy commented 8 years ago

Makes sense. I'll just update the docs for you then.

Will send a pull request hopefully later this evening.

m4robb commented 8 years ago

hey there, was having another idea for a feature request, is to pipe in audio from existing dom element on the page, either a audio or even better, a video element. This would be useful for the SynBios project, and others I think. But maybe there's a way to do that already with the existing code?

iainmcampbell commented 8 years ago

@m4robb it’s in the readme…