search

heliosdesign / helios-audio-mixer

Web Audio API mixer library
https://heliosdesign.github.io/helios-audio-mixer/demo
MIT License
60 stars 11 forks source link

Add semi-colons and update README. #13

Closed dansundy closed 8 years ago

dansundy commented 8 years ago

Added a semi-colon to the end of helios-audio-mixer.js and helios-audio-mixer.tone.js.

Made a small adjustment to README.md.

This closes #12.

dansundy commented 8 years ago

Also noticed that the docs say that tweenGain returns a promise. It looks like it does for HTML5, but not for regular mode. Maybe I'm missing something. Anyway, I'll leave that one with you.

iainmcampbell commented 8 years ago

thanks Dan!

I toyed with the idea of having tweenGain return a promise but realized it's more trouble than it's worth, as promises can't be cancelled and often you want to be able to override the tween. I've removed promises from the docs and the html version.