Closed JakubRakus closed 3 years ago
@JakubRakus thank you for the contribution! I will merge once I've had a chance to review but glad someone has finally contributed some ESP support since I am less familiar with that architecture. :)
Just a heads-up. I need pull requests on the develop branch. I'll see if I can merge over to it otherwise I will have to either copy your changes in or have you resubmit. Thanks.
@JakubRakus no need to resubmit. I looked up how to move your pull request to another branch. We should be good! Thanks again!
@MannyPeterson No problem! Next time I submit pull request to develop branch.
Changes I've made: 1) Support for ESP8266 - just add new section to HeliOS.h with
ARDUINO_ARCH_ESP8266
, identical to othersARDUINO_ARCH_xxx
. 2) Renamed macroNOW()
to something less generic:SYS_NOW()
- without this compiler warns about macro redefinition - NOW() macro is defined in some ESP-specific Arduino libraries. 3) ChangedTaskListItem_t *item = taskListHead
toTaskListItem_t *item = (TaskListItem_t*)taskListHead
in functionTaskListRemove()
- without this compiler warns about discarding volatile qualifier (taskListHead
is defined as volatile).Tested on NodeMCU board with ESP8266. Everything works like a charm and compiles without any warnings.