search

heliphix / btc_data

This repository contains the code and datasets for creating the machine learning models in the research paper titled "Time-series forecasting of Bitcoin prices using high-dimensional features: a machine learning approach"
https://doi.org/10.1007/s00521-020-05129-6
MIT License
52 stars 29 forks source link

Fix for datacollector.py #6

Closed jcfbeardsley closed 3 years ago

jcfbeardsley commented 3 years ago

Hi,

I found your manuscript for this repository to be really interesting - thanks for publishing! I'm now trying to independently recreate the results to better understand how LSTM and Keras work within Python.

It appears that a small fix for datacollector.py is required for scraping from bitinfocharts.com due to changes on the remote side. Line 100 should now be values=soup.find_all('script')[4].string when using Python 3.8 and BS4 >=4.9.3.

Thanks, J.

heliphix commented 3 years ago

Thanks for reporting the error. The code has been updated.