search

helium / HIP

Helium Improvement Proposals
Apache License 2.0
580 stars 408 forks source link

Update 0115 after account/wallet clarification #1034

Closed waveform06 closed 4 months ago

waveform06 commented 4 months ago

This includes all changes in PR 1032 plus updates after discussions with the author and clarification of the maker account/wallet/NFT with foundation devs.

@heatedlime Can you review this PR and if in agreement confirm in a comment below and withdraw https://github.com/helium/HIP/pull/1032 @ChewingGlass Apart from phase 2/phase 3 can you confirm this is correct? I believe those still need work and clarification

heatedlime commented 4 months ago

Good with all changes

abhay commented 4 months ago

Can we add to the HIP that Helium Foundation can implement a one-time transfer of DC from the existing maker onboarding wallet to the maker escrow wallet? The program will continue to use the remaining DC until it runs out, then start using the USDC, but adding this implementation will make things easier.

heatedlime commented 4 months ago

Can we add to the HIP that Helium Foundation can implement a one-time transfer of DC from the existing maker onboarding wallet to the maker escrow wallet? The program will continue to use the remaining DC until it runs out, then start using the USDC, but adding this implementation will make things easier.

Great idea. Add it.

hiptron commented 4 months ago

1035

abhay commented 4 months ago

@heatedlime can you do a review here and make sure the changes make sense?

abhay commented 4 months ago

Tried to clean up a bit.

heatedlime commented 4 months ago

Tried to clean up a bit.

Everything looks really good. I have no further edits/comments, and am good with the changes.