helium / HIP

Helium Improvement Proposals
Apache License 2.0
581 stars 407 forks source link

HIP29: Multi-signature Keys #157

Closed jamiew closed 3 years ago

jamiew commented 3 years ago

Author(s): @xandkar, @Vagabond, Helium Systems, Inc. team Start Date: 2021-04-19 Category: Technical Initial PR: #154 Status: In Discussion

Rendered view:

https://github.com/helium/HIP/blob/master/0029-multisignature-keys.md

Summary:

Hotspot owners, HNT holders, and other Helium participants, have different ways to organize assets. This HIP proposes a multi-signature key which can be used to authorize a transaction on the Helium blockchain. This key is a composite of the scalar keys which can be combined to generate a minimal subset of signatures required to make a valid transaction.

jamiew commented 3 years ago

There has been universally positive support for this HIP in GitHub commnents, Discord chats, the most recent community call and there were 100% "yes" votes from 49 people in a straw poll. In recognition of this I am pleased to recognize this HIP as approved by the Helium community and will update statuses accordingly.

image

jamiew commented 3 years ago

@xandkar @Vagabond would it be possible to link to any existing PRs in other repositories? Someone mentioned work was already in-flight

xandkar commented 3 years ago

@jamiew here's what's been done so far: Basic support: https://github.com/helium/libp2p-crypto/pull/10 Payment test: https://github.com/helium/blockchain-core/pull/777 Canonicalization of key order: https://github.com/helium/libp2p-crypto/pull/13

abhay commented 3 years ago

Close as implemented @jamiew ?

mfalkvidd commented 3 years ago

Is there any info/documentation on how to use multisig?

jamiew commented 3 years ago

@abhay yes please! Did this require a chainvar deployment? Do you have a favorite link to use for Deployed and/or Audit links?

jamiew commented 3 years ago

Is there any info/documentation on how to use multisig?

It's currently only available for chainvar transactions, imagine more will be coming later

abhay commented 3 years ago

Propose closing this as deployed @jamiew?

abhay commented 3 years ago

Now deployed – Same details as #158

abhay commented 3 years ago

Is there any info/documentation on how to use multisig?

It's currently only available for chainvar transactions, imagine more will be coming later

Actually not exactly. Chain vars use a different multisig model. This is for on chain accounts/keys.

mfalkvidd commented 3 years ago

If we can use multisig for accounts, some sort of documentation would be very useful.

GrahamJenkins commented 2 years ago

From what I have read, HIP 29 has been merged, however support for it needs to be added to helium-wallet. Until that has happened, there will be no effective way for users to utilize multi-sig, is that correct?

mfalkvidd commented 2 years ago

@GrahamJenkins yes that is correct

abhay commented 2 years ago

Initial support has been implemented in https://github.com/helium/helium-crypto-rs/pull/21 and additional support will need to be added to the CLI parts of https://github.com/helium/helium-wallet-rs to consider the rust wallet complete.