helium / HIP

Helium Improvement Proposals
Apache License 2.0
580 stars 408 forks source link

HIP 83: Restore First to Respond Witness Rewarding #632

Closed vincenzospaghetti closed 1 year ago

vincenzospaghetti commented 1 year ago

HIP 83: Restore First to Respond Witness Rewarding

Summary

Currently, the Proof-of-Coverage Oracles collect all the witnesses for a beacon and randomly reward a selection of 14 witnesses. This HIP proposes to revert to rewarding the first 14 Hotspots responding to a beacon, incentivizing the most useful Hotspots to sensor traffic by prioritizing the low latency connections that sensors need for uplinks, downlinks, and join requests to work correctly.

Motivation

Rewarding witnesses that are the first to respond will incentivize Hotspots to provide the low-latency connection that the sensors desperately need.

Sensors use uplinks to transfer their data over the Helium network. For a sensor to join the Helium network, it must perform a handshake that requires both an uplink and a downlink. As a power-saving measure, a sensor often has a limited time window to listen for the downlink.

Because the sensor only listens for the downlink for a limited time, the Helium LNS and the Hotspots must minimize latency to ensure the Hotspot can deliver downlinks to sensors within the narrow sensor listening window.

The Helium network originally rewarded the fastest witnesses and moved to a random selection for several technical reasons that no longer apply to the Oracle-based POC architecture introduced as part of HIP 70.

Technical limitations included, but are not limited to:

Rendered View

https://github.com/helium/HIP/blob/main/0083-restore-first-to-witness.md

Supporting Code

https://github.com/helium/oracles/compare/main...mawdegroot:oracles:mg/first-to-respond-witnessing

HeliosHyperion1111 commented 1 year ago

Several changes to the code have significantly improved the signing speed for the majority of makers. In preliminary testing the majority of makers now show a very similar signing performance. These changes will be included in the new gateway-rs v1.1.0 release which has been released to makers for testing. The new gateway-rs release will also include session keys which will significantly increase data transfer throughput and should free up time on the ECC chip for further improvements in high traffic areas.

great news, so how about we also open up the 14 only selected witnesses to 25? original choices need original choices not half original half w/e we want.

RuDee-BG commented 1 year ago

From past night something have been changed, my witnesses increased and the nearby miners with 3000-4000 iot per day has been decreased from its original state before hip83.

Something is cooking

Delitants commented 1 year ago

From past night something have been changed, my witnesses increased and the nearby miners with 3000-4000 iot per day has been decreased from its original state before hip83.

Something is cooking

Nothing has increased at all

Delitants commented 1 year ago

Where is the fix?

Firaso123 commented 1 year ago

So far no improvement at all at least for the three miners I own.

HeliosHyperion1111 commented 1 year ago

So far no improvement at all at least for the three miners I own.

same, feels like i have to wait for fiber infrastructure for my area to buy one program, all thanks to the number 1 culprit who pushed the hip 83 that was not needed. did more damage to the network than good, usage is dogsht. i look everyday the usage and its nowhere near what those pump n dump flactuations happened before the halving, seems like it was all just cuz of price volatility nothing else.

Delitants commented 1 year ago

I have fiber and I tell you what, it makes ZERO improvement on this HIP. So forget waiting for it.

HeliosHyperion1111 commented 1 year ago

I have fiber and I tell you what, it makes ZERO improvement on this HIP. So forget waiting for it.

do u have the fiber cable connected straight into the hotspot? have you tried that? cuz i think that will fix majority of the latency. also to add, switch DNS. 1.1.1.1 is by far the lowest latency that gives me.

Delitants commented 1 year ago

I have fiber and I tell you what, it makes ZERO improvement on this HIP. So forget waiting for it.

do u have the fiber cable connected straight into the hotspot? have you tried that? cuz i think that will fix majority of the latency. also to add, switch DNS. 1.1.1.1 is by far the lowest latency that gives me.

Fiber is connected to my router. You can't stick a fiber in the hotspot directly. Whatever they done here in this HIP is suppresses certain brands of the hotspots, especially those which have 5G function like FreedomFI. This shit must be downvoted or fixed. So far nothing changed

HeliosHyperion1111 commented 1 year ago

I have fiber and I tell you what, it makes ZERO improvement on this HIP. So forget waiting for it.

do u have the fiber cable connected straight into the hotspot? have you tried that? cuz i think that will fix majority of the latency. also to add, switch DNS. 1.1.1.1 is by far the lowest latency that gives me.

Fiber is connected to my router. You can't stick a fiber in the hotspot directly. Whatever they done here in this HIP is suppresses certain brands of the hotspots, especially those which have 5G function like FreedomFI. This shit must be downvoted or fixed. So far nothing changed

there is a way, if you do POE you can basicaly use 2 fiber cables, 1 for electricity and 1 for internet, converted into a POE with a male into female (ethernet) adaptor or w/e its called u know what i mean

Delitants commented 1 year ago

I have fiber and I tell you what, it makes ZERO improvement on this HIP. So forget waiting for it.

do u have the fiber cable connected straight into the hotspot? have you tried that? cuz i think that will fix majority of the latency. also to add, switch DNS. 1.1.1.1 is by far the lowest latency that gives me.

Fiber is connected to my router. You can't stick a fiber in the hotspot directly. Whatever they done here in this HIP is suppresses certain brands of the hotspots, especially those which have 5G function like FreedomFI. This shit must be downvoted or fixed. So far nothing changed

there is a way, if you do POE you can basicaly use 2 fiber cables, 1 for electricity and 1 for internet, converted into a POE with a male into female (ethernet) adaptor or w/e its called u know what i mean

You don't make any sense. PoE has nothing to do with fiber. And fiber at home is usually PON, which is locked to provider's ONT. You can't just plug it in wherever you want.

waveform06 commented 1 year ago

@HeliosHyperion1111 @RuDee-BG @Delitants Have you taken a look at https://github.com/helium/HIP/blob/main/0094-response-time-windows-for-witness-rewarding.md https://discord.com/channels/404106811252408320/1144746781071130795

HeliosHyperion1111 commented 1 year ago

@HeliosHyperion1111 @RuDee-BG @Delitants Have you taken a look at https://github.com/helium/HIP/blob/main/0094-response-time-windows-for-witness-rewarding.md https://discord.com/channels/404106811252408320/1144746781071130795

yeah i wait for this HIP to be released, but for the time being we all try to find a way to reduce our latency, most people don't find any other way other than upgrading to fiber network with fiber lines connected straight to our hotspots, most think you need the antenna as high as possible, well mine is at the highest point in the outskirts of the capital( omni directional ) in case some think that i have a directional ''stealing'' all the rewards. this HIP 83 has impacted my hotspot significantly cuz i provide very good coverage, i connect the capital city, with islands on the south + 1 small port city behind me and 1 small sub urban town on the north, and guess what? i got punished for it! haha thanks to HIP 83.

Delitants commented 1 year ago

@waveform06 What’s completed? All my FF gateways have a constant 7x reduce since this dumb hip was released. There is nothing changed.

madninja commented 1 year ago

@waveform06 What’s completed? All my FF gateways have a constant 7x reduce since this dumb hip was released. There is nothing changed.

  1. poc ingest streams will go live shortly which will help with security chip performance across all hotspots, including the FF hotspots because of the use of session keys
  2. a FF update will include this gateway-rs upgrade as well as a faster security chip (TPM) interface

And finally, this HIP was accepted and implemented in the reward system. The fact that one or more makers did not upgrade quickly is not a problem for the HIP, it's a problem with the maker.

If you still generally don't like the the concept of first to witness, propose a new alternate approach in a HIP or back one of the existing ones?

waveform06 commented 1 year ago

@Delitants Its completed in the sense that the HIP process is complete. Its now down to the hotspot vendors to improve their products response times and the core-devs to make any improvements to the system to provide an even playing field where possible for all vendors. https://github.com/helium/HIP/issues/764 is an alternative that is being evaluated

Delitants commented 1 year ago

I’m seeing a 200% increase today, looks like it’s getting back to normal. Thanks!On Oct 24, 2023, at 2:16 AM, Adrian @.***> wrote: @Delitants Its completed in the sense that the HIP process is complete. Its now down to the hotspot vendors to improve their products response times and the core-devs to make any improvements to the system to provide an even playing field where possible for all vendors.

764 is an alternative that is being evaluated

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>