search

helium / HIP

Helium Improvement Proposals
Apache License 2.0
580 stars 408 forks source link

Added network badges to README #979

Closed samgutentag closed 1 month ago

samgutentag commented 5 months ago

Saw this request in Discord and change was pretty simple to make.

image

[!IMPORTANT]
Someone please double check these! I pulled from heliumvote.com for some, others that have not yet been voted on or did not go to vote I took best judgements

Network Badge colors extracted from the SVGs on HeliumVote.com as follows.

Network Hex Code Preview
HNT #2755F8
IOT #26ED75
MOBILE #009EF8

Sample Preview of GitHub Rendering

ID Title Status Network
200 HNT Network Proposal
201 IOT Network Proposal
202 MOBILE Network Proposal
waveform06 commented 5 months ago

That was quick - amazing, I was thinking though. What would the badges mean? Voted with, or affects the network? Do some HIPs need more than one badge? HIPs 4 & 8- & 52 voted with HNT but affects IOT HIPs 7, 76 & 77 voted with HNT but affects all 3 HIP 12 voted with HNT but affects IOT and MOBILE

To help with knowing which HIPs defined each network going to be adding these to docs which could be a better lookup than badges https://docs.google.com/document/d/1wR07EgMd5mZQ02GY750LQ6bIeZ_6-zyWNvvtS_obvRo/ https://docs.google.com/document/d/18BqeT0-SK83KvaBNdyUKHNr0A9ZgRlEC2YQCUVahfcA/

samgutentag commented 5 months ago

good question, spirit of the original request was "type or category of hip" which I read more as "which network this impacts".

Pre-migration HIPs I think are fine to mark down as HNT, given thats all there was at the time, but maybe post migration HIPs (anythign after 70) we base it on the token used to vote?

waveform06 commented 5 months ago

HIP 110 will be 3 votes, so it will get 3 badges

samgutentag commented 5 months ago

the benefit and curse of modular governance haha here is a sample of that that could lol like

ID Title Status Network
200 HNT Network Proposal
201 IOT Network Proposal
202 MOBILE Network Proposal
110 Multi Badge Test
abhay commented 5 months ago

I like the idea of this from a visualization perspective. It might need some work on mobile but fine with landing it after a rebase.

samgutentag commented 5 months ago

nice! should be all set, updated HIP 119 to include the badge as well

abhay commented 5 months ago

did a quick reformat. probably needs a review of the tagging though. i think some of them are missing

Ridvan8899 commented 5 months ago

.

abhay commented 2 months ago

need a rebase before considering a merge.

samgutentag commented 1 month ago

This is closed, head to PR #1082 for more recent work