exclude infos, like blocks, from the internal hash

evanmcc commented 2 years ago

they contain maps, so the ordering is going to be different, and they are not properly part of the ledger.

Vagabond commented 2 years ago

You need a clause in hash() line 810 to handle it as well.

Vagabond commented 2 years ago

I tested this by doing the following:

Booting a validator from the latest blessed snap
Taking the same snapshot again and checking the hash matched the sys.config hash
Let the node sync a bit and then take a second snap on OTP22
Rebuild the release with OTP24 and take the snap again at the same height
Compare the hashes between OTP22 and OTP24

One thing I'm not sure about: can older nodes load a snap that is hashed differently? How did this node load a blessed snap that was hashed under the old rules? Does downloading from s3 bypass hash checking?

jadeallenx commented 2 years ago

downloading from s3 bypass hash checking?

It uses whatever internal hash is encoded in latest-snap.json - that hash comes from the snapshot info cmd line output

helium / blockchain-core

exclude infos, like blocks, from the internal hash #1234