helium / blockchain-core

Apache License 2.0
213 stars 85 forks source link

Add a top level function to save snapshots to disk #1293

Closed jadeallenx closed 2 years ago

jadeallenx commented 2 years ago

Problem to solve: Callers currently have to choose whether they want to store a compressed snapshot or uncompressed snapshot by function name.

Solution: Provide a function with the same interface that can store compressed, uncompressed, or both types of snapshots. Adds a new environment variable snapshot_compression_mode. Defaults to compressed

madninja commented 2 years ago

I'd rename it to save_bin_snapshots (note the plural) and use that as the single entry point for multi binary snapshot saves? Keeps the name more consistent imo