helium / blockchain-core

Apache License 2.0
213 stars 86 forks source link

only promote proposal if outside of gc window #1331

Closed andymck closed 2 years ago

andymck commented 2 years ago

This adds a check to the promotion of proposals to consider if the proposal is within the GC window. If it is then dont select it. This is necessary as not doing so could lead to potential sync problems if the chain var poc_validator_ephemeral_key_timeout is modified.

evanmcc commented 2 years ago

https://github.com/helium/blockchain-core/blob/9c5284871d48bc018fa7d4de6a056a64eac10d74/src/ledger/v1/blockchain_ledger_v1.erl#L2346

There will need to be safety logic here to the tune of:

evanmcc commented 2 years ago

please see #1335