search

helium / blockchain-core

Apache License 2.0
213 stars 86 forks source link

fix proposal and public GC. Only include poc if correctly promoted #1333

Closed andymck closed 2 years ago

andymck commented 2 years ago

Addresses two issues

  1. during GC of POCs, a fun is created and then used to purge the two POC related CFs ( proposals and public ). However when deleting a POC it would only delete it from the public poc CF, even if the intended POC to GC was a proposal.

  2. when promoting a poc proposal, only do so if the promotion was a success. Previously if the promotion returned an error we would still include the POC in the event published for downstream components such as sibyl and miner. This could result in a POC being initiated which does not actually exist on the ledger

it is hoped that these fixes will address the error seen when a validator is in consensus and it attempts to submit a v2 receipt:

2022-05-09 17:06:27.183 [warning] <0.7699.31>@blockchain_txn_poc_receipts_v2:check_is_valid_poc:{195,13} poc_id=7Lt1mh7M8vugeGWQAd-zq1t7CogtNORGVID8eqPGTeE poc_receipts error find_public_poc, poc_onion_key_hash: <<236,187,117,154,30,204,242,251,160,120,101,144,1,223,179,171,91,123,10,136,45,52,228,70,84,128,252,122,163,198,77,225>>, reason: not_found 2022-05-09 17:06:27.183 [warning] <0.4286.0>@miner_hbbft_sidecar:handle_info:{247,25} is_valid failed for type=poc_receipts_v2 hash="12SCj9T6GcjxUPDwSPjroRrP3rizpyTMo8utW86ATVTuNqriMF8" challenger="delightful-mahogany-kitten" onion="12oG1ThKEPP6Du3aoLubtXqAwKSqennSp3hXAwZWSQife53eF4M" path: type=element challengee: cheery-mandarin-terrier, receipt: type=receipt gateway: cheery-mandarin-terrier timestamp: 1652113826963722514 signal: 0 snr: 0.0 freq: 0.0 origin: p2p, tx_power: 19 witnesses: , error: {error,not_found} 2022-05-09 17:06:27.184 [error] <0.5049.31>@miner_poc_mgr:-purge_local_pocs/2-fun-0-:660 CRASH REPORT Process miner_poc_mgr with 0 neighbours crashed with reason: no match of right hand value {{error,not_found},17319} in miner_poc_mgr:'-purge_local_pocs/2-fun-0-'/7 line 660

I am not 100% the fixes here will address this completely, I have not been able to reproduce. Will monitor again once deployed

Vagabond commented 2 years ago

I think we need this guarded behind a var :/

andymck commented 2 years ago

fixed here: cd56ae916686d935de86af8b7bca4adc79297bc4