Open dpezely opened 1 year ago
We added the dep to the app file so this maybe doesn't need to be reverted?
We added the dep to the app file so this maybe doesn't need to be reverted?
Now, I'm really confused. New tests wouldn't have passed prior to creating the original PR if there was such a missing dependency.
Everything with blockchain-core remain a bit alien to me since I don't follow the relevant Discord channels or its PRs closely enough. Therefore, I'll leave that decision to others. My rationale was that if this feature requires a chain var which has been put on hold, there's no reason for this feature code to exist (for now).
Fix https://github.com/helium/miner/issues/1779 by reverting https://github.com/helium/blockchain-core/pull/1412 per conversation with @mikev
test/blockchain_state_channel_SUITE.erl