search

helium / blockchain-core

Apache License 2.0
214 stars 85 forks source link

Teardown region cache on delayed ledger absorb #1492

Closed vihu closed 1 year ago

vihu commented 1 year ago

Summary

Sooner rather than later we'll have to issue some more region related vars, there's already some reports of region misalignment (Kazakhstan still on EU433 for example, instead of IN865). I think this change will help to hopefully avoid the delayed ledger cache being inconsistent on a region var change.

Vagabond commented 1 year ago

I don't think this is the fix we need, I believe the problem comes from an inappropriate call to blockchain_region_v1:h3_to_region/3 with a regionvars from before the var change, which corrupts the cache. We should try to check the vars nonce for the regionvars is the same as the one in the ledger somehow.

vihu commented 1 year ago

I don't think this is the fix we need, I believe the problem comes from an inappropriate call to blockchain_region_v1:h3_to_region/3 with a regionvars from before the var change, which corrupts the cache. We should try to check the vars nonce for the regionvars is the same as the one in the ledger somehow.

Hmm, fair. Closing this one then.