helium / blockchain-core

Apache License 2.0
213 stars 86 forks source link

Support for adding light gateways #735

Open Vagabond opened 3 years ago

Vagabond commented 3 years ago

Now most of the groundwork has been laid for light gateways, it's time to add a way to add them to the chain.

For simplicity the plan is to re-use the existing add_gateway txn but if the 'payer' is not one of the accounts blessed in the staking_keys chain variable we will add the gateway as a light gateway. Light gateways will only cost $20 to onboard, not $40 and will only be able to, initially, forward device packets.

A chain var will be added to allow the capabilities of light gateways to be ratcheted forwards as we build out more functionality (witnessing/being challenged, etc).

abhay commented 3 years ago

We may have to remember to allow the old staking_key in the permitted list.

Vagabond commented 3 years ago

No, because that was valid in the ledger at the time, but it no longer is.

We may have to remember to allow the old staking_key in the permitted list.

No, that was valid at the time it was valid, but it's been revoked so new transactions do not need to honor it.

abhay commented 3 years ago

No, that was valid at the time it was valid, but it's been revoked so new transactions do not need to honor it.

Ah, so we'll just grandfather everyone in for now. SG

Vagabond commented 3 years ago

Yes, all existing gateways should be designated as full.

timcooijmans commented 3 years ago

I have a question that I think best belongs here: Based on the recently merged pull request, it seems that theres an intention to support light-gateways from approved Makers. These light-gateways only have to pay a 20 USD-equivalent fee for the add_gateway transaction.

Will these light-gateways from approved Makers be eligible for earning for proof-of-coverage once this is supported?

Previously my understanding was that PoC-ing light-gateways would have to pay the full 40 USD fee and only never PoC-ing light-gateways would have to pay the 20 USD fee, but in this case I see no reason to onboard non-PoC-ing light-gateways to the onboarding server as a Maker, because non-onboarded DIY-like light-gateways will earn the same.

So TL;DR: Will light-gateways from approved Makers that were onboarded using the 20 USD fee earn for proof-of-coverage some day?

bitlite commented 3 years ago

Will these light-gateways from approved Makers be eligible for earning for proof-of-coverage once this is supported?

That is the ticket as per the definition of light hotspots. Light hotspots will not include any P2P systems and therefore will work with the Validators for POC.

Previously my understanding was that PoC-ing light-gateways would have to pay the full 40 USD fee and only never PoC-ing light-gateways would have to pay the 20 USD fee, but in this case I see no reason to onboard non-PoC-ing light-gateways to the onboarding server as a Maker, because non-onboarded DIY-like light-gateways will earn the same.

There will be 3 types of units.