search

helium / blockchain-etl

Blockchain follower that follows and stores the Helium blockchain
Apache License 2.0
64 stars 37 forks source link

Adds location geo search #137

Closed madninja closed 3 years ago

madninja commented 3 years ago

This adds a postgis extensioon dependency and a geometry column and index for locations.

It also adds a backfill location_geometry to backfill locations with their geometry information.

jamiew commented 3 years ago

:fire:

Any opinions on backwards-compatibility? I have a similar question with the .env change but don't have strong opinion either way.

It breaks headless updates, but could just alert people in #blockchain whenever there's a change requiring manual intervention

madninja commented 3 years ago

The .env issue is a breaking change which needs to get patched up. I missed that when doing the .env changes in the Makefile

The location search changes are a new route, and added migrations so a normal migration and restart would work as always.

On Sun, Mar 21, 2021 at 11:10 AM Jamie Wilkinson @.***> wrote:

🔥

Any opinions on backwards-compatibility? I have a similar question with the .env change but don't have strong opinion either way.

It breaks headless updates, but could just alert people in #blockchain whenever there's a change requiring manual intervention

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/helium/blockchain-etl/pull/137#issuecomment-803612363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACZBXBS4VV52L64IUTO6LTEYLBBANCNFSM4ZRRMT3A .

jamiew commented 3 years ago

Cool, I will adjust my .env patch this evening to be backwards-compatible. Adds more code but nice to not break anything