Fixing the recoding of the HTLC burn

helium / blockchain-etl

Blockchain follower that follows and stores the Helium blockchain

Apache License 2.0

64 stars 37 forks source link

Fixing the recoding of the HTLC burn #195

Closed maco2035 closed 3 years ago

maco2035 commented 3 years ago

The lines changed from 103-108. This adds the functionality to it.

The implicit burn was missing from the ETL, from HTLC transcations. Even thought the core had no problem with it.

I urge some caution, and need some review with this pull request, as I am unable to run an ETL to test transactions of this. As mine is about 400k blocks away, and needing a new hard drive soon.

madninja commented 3 years ago

This is quite incorrect.. This PR adds the wrong burn type for fees for htlc_create. In addition, transaction fees are already handled by:

https://github.com/helium/blockchain-etl/blob/master/src/be_db_dc_burn.erl#L117

Note that dc_burns is only for explicit burns. Implicit burns are not handled by etl yet, but this PR certainly does not address that lacking feature