search

helium / blockchain-etl

Blockchain follower that follows and stores the Helium blockchain
Apache License 2.0
64 stars 37 forks source link

Extend the address component search to all entries #243

Closed madninja closed 3 years ago

madninja commented 3 years ago

Only the first address components of the result list was previously searched for geocode fields.

This change has it search all address component entries in order for the first one that has a result for both long and short name.

After deploying this delete all rows in the locations table with a null short/long entry by running backfill gateway_location_clear_nulls. The geocoder will re-geocode the missing rows.

Fixes #235

abhay commented 3 years ago

After deploying this delete all rows in the locations table with a null short/long entry to get the geocoder to recode that hex location

Should we just add a migration that will delete those rows for you and the geocoder job will pick them up for geocoding again?

madninja commented 3 years ago

Hmm. As part of backfill maybe. I’m not really into a migration for this

Sent from my iPhone

On Sep 27, 2021, at 17:08, Abhay Kumar @.***> wrote:

 After deploying this delete all rows in the locations table with a null short/long entry to get the geocoder to recode that hex location

Should we just add a migration that will delete those rows for you and the geocoder job will pick them up for geocoding again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

abhay commented 3 years ago

Hmm. As part of backfill maybe. I’m not really into a migration for this

Sounds good.

HeliumKosovo commented 3 years ago

The entire country Kosovo has been having this issue(all miners) last 25 days, it wasn't before , region undefined/ null .. So when is this getting fixed , our miners hasn't been working and we been losing alot , is it something we need to do or you will fix it ? Plz better explanation

madninja commented 3 years ago

This issue is not new.. The country code used to infer the lora regional parameters was always looked up using the API country for a given location. Since this uses the Google geocoder it relies on geocoding data provided by Google. Kosovo is not returned as a country code by Google today.

Thankfully this will get fixed when PoC v11 is activated since it uses the LoraWaN regional definitions which will be on chain to determine the regional settings for your hotspots.