helium / blockchain-etl

Blockchain follower that follows and stores the Helium blockchain
Apache License 2.0
64 stars 37 forks source link

Gateway Offline Status does not match inactivity period in Validator PoC code #342

Closed BigEnigma closed 2 years ago

BigEnigma commented 2 years ago

Hi

The current ETL for the gateway_status table uses :

https://github.com/helium/blockchain-etl/blob/cbfaf9bb71129b525f9192a5450f1d713a16e94d/src/be_db_gateway_status.erl#L43

However the PoC based activity is using a chain variable currently set to 3600. With a more proactive reactivation scheme keep things active when they reach this age and are connected to a validator it is probably worth updating this.

If it could the chain variable this might be quit good, of course if the chain var changes then the whole gateway_status table might need updating. Didn't feel I knew the right way to correct this longer terms so didn't go for a PR.

Thanks