helium / blockchain-http

An http API for the helium blockchain database
https://helium.com
Apache License 2.0
47 stars 18 forks source link

The API to List Hotspot Cities is missing some data #399

Open Working4u opened 2 years ago

Working4u commented 2 years ago

The API to List Hotspot Cities is missing some data. Only the cities that have the fist letter after "S" are returned.

I tried to get the complete list of cities that have hotspots using GET https://api.helium.io/v1/cities

I used the cursor to navigate through all the pages.

Steps to reproduce:

(step 1) Calling https://api.helium.io/v1/cities => cursor: eyJyYW5rIjoiIiwiY2l0eV9pZCI6ImhsYXZuw60gbcSbc3RvIHByYWhhY3plY2hpYSJ9 Found 0 cities with defined short_city

(step 2) Calling https://api.helium.io/v1/cities?cursor=eyJyYW5rIjoiIiwiY2l0eV9pZCI6ImhsYXZuw60gbcSbc3RvIHByYWhhY3plY2hpYSJ9 => cursor: eyJyYW5rIjoiIiwiY2l0eV9pZCI6InNha2FyeWF0dXJrZXkifQ Found 0 cities with defined short_city

(step 3) Calling https://api.helium.io/v1/cities?cursor=eyJyYW5rIjoiIiwiY2l0eV9pZCI6InNha2FyeWF0dXJrZXkifQ => cursor: eyJyYW5rIjoiU2FsZW0iLCJjaXR5X2lkIjoic2FsZW11dGFodW5pdGVkIHN0YXRlcyJ9] Found 36 cities with defined short_city ...

(step 93) Calling https://api.helium.io/v1/cities?cursor=eyJyYW5rIjoi5p2x5Y2AIiwiY2l0eV9pZCI6IuadseWNgOWPsOWNl-W4gnRhaXdhbiJ9 => no cursor! Found 38 cities with defined short_city finish!

You can check all the results here: https://chartsmon.com/upload/helium-api-cities.txt

Please fix the API to get also the cities that start with letters from A to R!

nicolefriasb commented 2 years ago

Had same problem... doesn't fetch those cities. I got the city_id from searching a random hotspot in that city.