search

helium / explorer

A Helium Blockchain Explorer
Apache License 2.0
124 stars 136 forks source link

Show total HNT rewarded on reward txn view #28

Closed allenan closed 4 years ago

allenan commented 4 years ago

We should show the total amount rewarded in a reward txn as an attribute in the top section of the page.

Screen Shot 2020-10-06 at 12 04 26 PM
MohdImran001 commented 4 years ago

Hii @allenan, I'd love to work on this.

allenan commented 4 years ago

It's yours @MohdImran001. I was imagining some kind of icon and then the total next to it, like we show block height there as an attribute.

MohdImran001 commented 4 years ago

Hii @allenan, do have any suggestions that what icon I should use from ant-design and It would be great if you could share a link to a sample reward transaction, it will help me to test my changes easily.

MohdImran001 commented 4 years ago

Hey @allenan, sorry to press you and sorry for already sending you a message, but Hacktoberfest is ending soon and I need to make 2 more PR's to qualify. I am learning a lot from this project and I'd really appreciate it if you could share a link to a reward transaction and your suggestion about the icon.

allenan commented 4 years ago

Hey @MohdImran001 sorry missed your first message. Let's just use the WalletOutlined icon from ant for now. it'll be easy to swap out later

image

MohdImran001 commented 4 years ago

Hii @allenan, It would be great if you could share a link to a reward transaction. it would help me to test my changes easily.

allenan commented 4 years ago

@MohdImran001 that would certainly be helpful :)

https://explorer.helium.com/txns/wIBfrVocgH97Y1jFBctmzntP50hdWx8h-gW7fu7p2qo

allenan commented 4 years ago

resolved by #59