search

helium / helium-js

Official TypeScript packages for interacting with the Helium blockchain
Apache License 2.0
110 stars 35 forks source link

fix token type #325

Closed allenan closed 2 years ago

allenan commented 2 years ago

token type comes from the API as a lowercase ticker. We will preserve that interface up until transaction serialization at which point it gets converted to an integer, following the protobuf enum. This also removes the dependency on @helium/transactions from @helium/currency and @helium/http

allenan commented 2 years ago

Looking good, I think it would be valuable to handle testnet with this PR as well.

sounds like testnet does not alter the token_type fields in its responses, so any handling we want to do for testnet will need to happen outside of the currency/token_type level