search

helium / helium-ledger-app

The official Helium app for the Ledger Nano S
Apache License 2.0
32 stars 8 forks source link

Support for Ledger Nano S Plus? #57

Closed sabifa closed 2 years ago

sabifa commented 2 years ago

I bought a Ledger Nano S Plus to use it as my HNT wallet.

Unfortunately it looks like the helium-ledger-app is not supported for this device as I can't find the app in the Manager section of Ledger Live. App catalog missing Helium app

Proof of activated developer mode: developer mode is enabled

Ledger Live version is: 2.39.2

Can someone confirm whether helium-ledger-app works with the new Ledger Nano S Plus?

If not, is there a planned release to support it?

This repo has not been updated since November, is it even still maintained?

lthiery commented 2 years ago

@sabifa It's a little confusing, but this repo gets merged periodically into the LedgerHQ hosted one. So I have some branches here with some work and some PRs that are open or recently landed over there. From time to time, I sync their main branch back to this main branch.

Anyway, all that to say is that a new release is on the way. And I believe the LedgerHQ team was nice enough to add Nano S Plus support.

I'm not sure how long until they release it though. Hopefully the next few weeks?

sabifa commented 2 years ago

@lthiery Thank you very much for the super fast response and good news!

I will keep an eye on the LedgerHQ repo and report back once the update for the Nano S Plus got shipped.

iperrealistico commented 2 years ago

Let's wait then. I am in the same situation. Just bought my first ledger and it's a Nano S Plus, just to use it with Helium

sabifa commented 2 years ago

@lthiery Do you happen to know at what intervals a new release is normally provided by the ledger team? It's been 30 days since @Saltari added support for the Nano S Plus judging by his commit.

lthiery commented 2 years ago

@sabifa We're getting there! This new release has the new transactions (payment_v2 and security transfer), Nano S Plus support, and I've been working through the security review the past few days. I can't say for certain but it's looking like it's coming very soon.

sabifa commented 2 years ago

Thank you very much for the update! I really appreciate all the effort you put into this 🎉

lthiery commented 2 years ago

@sabifa i believe 2.2.3 is available for the S Plus now. Let me know if it works for you?

sabifa commented 2 years ago

@lthiery Just checked and indeed it is now listed in the App catalog for the S Plus! 🚀 Will create my wallet later today and report back.

Thanks for your contributions!

Edit: Everything works, I will close this issue now.

lthiery commented 2 years ago

@Leonardo-Fiori S Plus release confirmed by the way

iperrealistico commented 2 years ago

Yep! Finally I can see it! 👯‍♀️ Will test it today