helium / helium-wallet-rs

Rust implementation of a helium wallet CLI
Apache License 2.0
258 stars 114 forks source link

Allow wallet to post externally created txns #112

Closed ericjohncarlson closed 3 years ago

ericjohncarlson commented 3 years ago

With @deasydoesit's additions for the ability for the helium wallet to create transactions offline, this allows a user to create a wallet, stake a validator, transfer a validator and create a payment transaction all while in an air gapped state. This txn then can be posted manually to the API through a variety of methods.

A way to make this air gapped situation more approachable would be to allow a non-air gapped helium wallet binary to post a txn that was created from an air gapped wallet.

The process would be:

This would allow users who are unfamiliar with the API to post transactions.

madninja commented 3 years ago

So creating and posting a json blob to the pending_transactions endpoint of the form

{
    "txn": "<base64>"
}

is not easy enough?

ericjohncarlson commented 3 years ago

I don't know why a Helium network user needs to be an expert in posting json to API endpoints from the command line to be able to run a pay or stake transaction if they want to keep their wallet air-gapped, but if you feel this is a stretch in functionality and not needed, then mark it closed.

The ability for the Helium mobile app to post a txn from an offline wallet generated QR code would be way to go.

madninja commented 3 years ago

I don't know why a Helium network user needs to be an expert in posting json to API endpoints from the command line to be able to run a pay or stake transaction if they want to keep their wallet air-gapped, but if you feel this is a stretch in functionality and not needed, then mark it closed.

I was just asking.. hence the not closing..

The ability for the Helium mobile app to post a txn from an offline wallet generated QR code would be way to go.