search

helium / helium-wallet-rs

Rust implementation of a helium wallet CLI
Apache License 2.0
258 stars 114 forks source link

Fix data only by adding tx confirmation #333

Closed ChewingGlass closed 1 year ago

jthiller commented 1 year ago

This still returns { "result": "ok" }. Can we add some clarification around using --commit to assist on #332?

madninja commented 1 year ago

This still returns { "result": "ok" }. Can we add some clarification around using --commit to assist on #332?

so technically if you do not pass --commit the client would preflight the transaction to verify that it's all ready to go.. In practice that has not worked well at all since most of our transactions can't really be pre-flighted well AFAICT. The result is that currently without the commit flat it just parses the params and constructs the txn. And with the commit flag it submits it.

madninja commented 1 year ago

@jthiller Note that this commit ddc2ca4 removes the --subdao flag.. as in you just pass in iot or mobile to align it with the other wallet commands